Skip to content

ci: re-enable winvfs tests#12515

Merged
modSpike merged 3 commits intomasterfrom
ci/re-enable-winvfs-tests
Apr 17, 2026
Merged

ci: re-enable winvfs tests#12515
modSpike merged 3 commits intomasterfrom
ci/re-enable-winvfs-tests

Conversation

@erikjv
Copy link
Copy Markdown
Contributor

@erikjv erikjv commented Apr 16, 2026

On Windows, when using the CfApi, running tests in parallel could interfere in syncroot creation/registration. Forcing to run only a single test at a time seems to eliminate all problems.

@update-docs
Copy link
Copy Markdown

update-docs Bot commented Apr 16, 2026

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

erikjv added 3 commits April 16, 2026 17:16
This should prevent interference between tests that register/unregister
syncroots with CfApi.
@erikjv erikjv force-pushed the ci/re-enable-winvfs-tests branch from 10b64bf to 9b1180b Compare April 16, 2026 15:17
Copy link
Copy Markdown
Contributor

@modSpike modSpike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving anyway but if Thomas can answer my question, awesome

Comment thread .github/workflows/main.yml
Copy link
Copy Markdown
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it compiles ....

@modSpike modSpike merged commit 944975f into master Apr 17, 2026
9 checks passed
@modSpike modSpike deleted the ci/re-enable-winvfs-tests branch April 17, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants